[Bridge] [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

David Laight David.Laight at ACULAB.COM
Fri Jun 6 08:48:48 UTC 2014

From: David Miller [mailto:davem at davemloft.net]
> > br_manage_promisc() incorrectly expects br_auto_port() to return only 0
> > or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK.
> >
> > Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
> I'm applying this as-is for now, even though I saw the other
> suggestions in this thread (which BTW didn't get picked up by
> patchwork, maybe some of you dropped the Message-Id in your replies by
> accident).

I don't have a problem with that.
The condition looks odd, but it is enabling promiscuous mode
if any other ports are in 'auto' mode.
Possibly the comment above made that clear, but it was truncated
in the diffs.


More information about the Bridge mailing list