[Bridge] [PATCH] list: Fix order of arguments for hlist_add_after(_rcu)
David.Laight at ACULAB.COM
Fri Jun 6 15:56:52 UTC 2014
From: Behalf Of Ken Helias
> All other add functions for lists have the new item as first argument and the
> position where it is added as second argument. This was changed for no good
> reason in this function and makes using it unnecessary confusing.
> Also the naming of the arguments in hlist_add_after was confusing. It was
> changed to use the same names as hlist_add_after_rcu.
> -static inline void hlist_add_after_rcu(struct hlist_node *prev,
> - struct hlist_node *n)
> +static inline void hlist_add_after_rcu(struct hlist_node *n,
> + struct hlist_node *prev)
It is rather a shame that the change doesn't generate a compilation
error for old source files.
More information about the Bridge