[Bridge] [PATCH net] bridge: Fix memory leak in br_dev_xmit

Toshiaki Makita toshiaki.makita1 at gmail.com
Sun Mar 30 02:41:35 UTC 2014


On Sat, 2014-03-29 at 16:40 +0900, Toshiaki Makita wrote:
> On Fri, 2014-03-28 at 09:34 -0700, Stephen Hemminger wrote:
> > On Fri, 28 Mar 2014 15:21:19 +0900
> > Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote:
> > 
> > > When a frame is rejected by br_allowed_ingress(), the skb is not freed.
> > > 
> ...
> > Increment dev->tx_dropped?
> 
> OK, I'll rework it.

After investigating bridge codes, I found br_cpu_netstats doesn't have
tx_dropped field.
I'm thinking about adding that field, but it seems to be appropriate for
net-next. I'm resending this patch as is for now.

Thanks,
Toshiaki Makita



More information about the Bridge mailing list