[Bridge] [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed

Stephen Hemminger stephen at networkplumber.org
Fri May 30 14:34:46 UTC 2014


On Thu, 29 May 2014 10:15:30 +0800
Wang Weidong <wangweidong1 at huawei.com> wrote:

> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
> 
> Signed-off-by: Wang Weidong <wangweidong1 at huawei.com>

Good catch.
Acked-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the Bridge mailing list