[Bridge] [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

Stephen Hemminger stephen at networkplumber.org
Thu Jul 23 16:59:45 UTC 2015


On Thu, 23 Jul 2015 09:07:37 -0700
Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:

> +		/* Stop hello and hold timer */
> +		spin_lock_bh(&br->lock);
> +		del_timer(&br->hello_timer);
> +		list_for_each_entry(p, &br->port_list, list)
> +			del_timer(&p->hold_timer);
> +		spin_unlock_bh(&br->lock);

Wouldn't it be easier to use del_timer_sync here?


More information about the Bridge mailing list