[Bridge] [PATCH net] bridge: fix igmpv3 / mldv2 report parsing

David Miller davem at davemloft.net
Fri Sep 11 22:09:04 UTC 2015


From: Linus Lüssing <linus.luessing at c0d3.blue>
Date: Fri, 11 Sep 2015 18:39:48 +0200

> With the newly introduced helper functions the skb pulling is hidden in
> the checksumming function - and undone before returning to the caller.
> 
> The IGMPv3 and MLDv2 report parsing functions in the bridge still
> assumed that the skb is pointing to the beginning of the IGMP/MLD
> message while it is now kept at the beginning of the IPv4/6 header,
> breaking the message parsing and creating packet loss.
> 
> Fixing this by taking the offset between IP and IGMP/MLD header into
> account, too.
> 
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
> Reported-by: Tobias Powalowski <tobias.powalowski at googlemail.com>
> Tested-by: Tobias Powalowski <tobias.powalowski at googlemail.com>
> Signed-off-by: Linus Lüssing <linus.luessing at c0d3.blue>

There were many serious regressions introduced by that commit, I'm
extremely disappointed.

Patch applied and queued up for -stable, thanks.


More information about the Bridge mailing list