[Bridge] [PATCH] bridge: Fix format string for %ul

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Sat Aug 27 16:18:16 UTC 2016


On 8/27/2016 6:58 PM, Oleg Drokin wrote:

>>> %ul would print an unsigned value and a letter l,
>>> likely it was %lu that was meant to print the long int,
>>> but in reality the values printed there are just regular signed
>>   Signed? Then you need probably "%d" or "%i"…
> They are signed in the struct definition, but in reality they
> designate time, so could not be negative, I imagine?

    That doesn't matter. If the type is signed, it should be printed as signed.
Doesn't gcc complain about the format specifiers not matching the values passed?

>>> ints, so just dropping the l altogether.
>>> Signed-off-by: Oleg Drokin <green at linuxhacker.ru>
>> [...]

MBR, Sergei

More information about the Bridge mailing list