[Bridge] [PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type

Nikolay Aleksandrov nikolay at cumulusnetworks.com
Tue Aug 30 15:10:59 UTC 2016


On 30/08/16 17:00, Nikolay Aleksandrov wrote:
> On 30/08/16 16:59, Stephen Hemminger wrote:
[snip]
>>>  	if (p->state == BR_STATE_LEARNING)
>>>  		goto drop;
>>>  
>>>  	BR_INPUT_SKB_CB(skb)->brdev = br->dev;
>>>  
>>> -	local_rcv = !!(br->dev->flags & IFF_PROMISC);
>>> -
>>>  	if (IS_ENABLED(CONFIG_INET) && skb->protocol == htons(ETH_P_ARP))
>>>  		br_do_proxy_arp(skb, br, vid, p);
>>>
>>
>> can't proxy_arp change what was a broadcast packet into a unicast packet?
>>
> 

Sorry I missed this question, no it shouldn't be possible. The proxy arp
code only inspects the skb and acts accordingly, it doesn't do any
modifications IIRC.



More information about the Bridge mailing list