[Bridge] [PATCH net-next v2] bridge: fdb add and delete tracepoints

Florian Fainelli f.fainelli at gmail.com
Tue Aug 29 16:46:05 UTC 2017


On 08/28/2017 09:22 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa at cumulusnetworks.com>
> 
> A few useful tracepoints to trace bridge forwarding
> database updates.
> 
> Signed-off-by: Roopa Prabhu <roopa at cumulusnetworks.com>

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>

Small nit below, but probably not a candidate for a v3

> ---

> +
> +	TP_printk("dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u nlh_flags %04x ndm_flags = %02x",

Small nit, any particular reason why ndm_flags got a special treatment
with an equal character and not the other?

> +		  __get_str(dev), __entry->addr[0], __entry->addr[1],
> +		  __entry->addr[2], __entry->addr[3], __entry->addr[4],
> +		  __entry->addr[5], __entry->vid,
> +		  __entry->nlh_flags, __entry->ndm_flags)
-- 
Florian


More information about the Bridge mailing list