[Bridge] [PATCH][net-next] net: bridge: remove redundant check to see if err is set

Colin King colin.king at canonical.com
Tue Feb 7 10:56:38 UTC 2017

From: Colin Ian King <colin.king at canonical.com>

The error check on err is redundant as it is being checked
previously each time it has been updated.  Remove this redundant

Detected with CoverityScan, CID#140030("Logically dead code")

Signed-off-by: Colin Ian King <colin.king at canonical.com>
 net/bridge/br_netlink.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index fc5d885..cdc4e2a 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br,
 				return err;
-		if (err)
-			return err;
 	return err;

More information about the Bridge mailing list