[Bridge] [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

[Nikolay Aleksandrov]

On 5/19/17 8:30 PM, Ivan Vecera wrote:
> Current bridge code incorrectly handles starting/stopping of hello and
> hold timers during STP enable/disable.
> 
> 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
>     transition. The timers are already stopped in NO_STP state so
>     this is confusing no-op.
> 
> 2. During USER_STP->NO_STP transition the timers are started. This
>     does not make sense and is confusion because the timer should not be
>     active in NO_STP state.
> 
> Cc: davem at davemloft.net
> Cc: sashok at cumulusnetworks.com
> Cc: stephen at networkplumber.org
> Cc: bridge at lists.linux-foundation.org
> Cc: lucien.xin at gmail.com
> Cc: nikolay at cumulusnetworks.com
> Signed-off-by: Ivan Vecera <cera at cera.cz>
> ---
>   net/bridge/br_stp_if.c | 11 -----------
>   1 file changed, 11 deletions(-)
> 

LGTM, thanks!

Acked-by: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>