[Bridge] [PATCH net-next v6 2/2] bridge: vlan: signal if anything changed on vlan add

Toshiaki Makita toshiaki.makita1 at gmail.com
Fri Oct 27 23:34:03 UTC 2017


On 17/10/27 (金) 19:19, Nikolay Aleksandrov wrote:
> Before this patch there was no way to tell if the vlan add operation
> actually changed anything, thus we would always generate a notification
> on adds. Let's make the notifications more precise and generate them
> only if anything changed, so use the new bool parameter to signal that the
> vlan was updated. We cannot return an error because there are valid use
> cases that will be broken (e.g. overlapping range add) and also we can't
> risk masking errors due to calls into drivers for vlan add which can
> potentially return anything.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>

Reviewed-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>

Toshiaki Makita


More information about the Bridge mailing list