[Bridge] [PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()
Vivien Didelot
vivien.didelot at savoirfairelinux.com
Tue May 29 12:42:40 UTC 2018
Hi Petr,
Petr Machata <petrm at mellanox.com> writes:
> A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves
> initializing a struct switchdev_obj_port_vlan, a piece of code that
> repeats on each call site almost verbatim. While in the current codebase
> there is just one duplicated add call, the follow-up patches add more of
> both add and del calls.
>
> Thus to remove the duplication, extract the repetition into named
> functions and reuse.
>
> Signed-off-by: Petr Machata <petrm at mellanox.com>
Considering Dan's comment as well:
Reviewed-by: Vivien Didelot <vivien.didelot at savoirfairelinux.com>
Thanks,
Vivien
More information about the Bridge
mailing list