[Bridge] [PATCH net-next v2] net: bridge: add STP xstats
Vivien Didelot
vivien.didelot at gmail.com
Wed Dec 11 02:02:03 UTC 2019
Hi Nikolay,
On Tue, 10 Dec 2019 23:45:13 +0200, Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:
> > + if (p) {
> > + nla = nla_reserve_64bit(skb, BRIDGE_XSTATS_STP,
> > + sizeof(p->stp_xstats),
> > + BRIDGE_XSTATS_PAD);
> > + if (!nla)
> > + goto nla_put_failure;
> > +
> > + memcpy(nla_data(nla), &p->stp_xstats, sizeof(p->stp_xstats));
>
> You need to take the STP lock here to get a proper snapshot of the values.
Good catch! I see a br->multicast_lock but no br->stp_lock. Is this what
you expect?
spin_lock_bh(&br->lock);
memcpy(nla_data(nla), &p->stp_xstats, sizeof(p->stp_xstats));
spin_unlock_bh(&br->lock);
Thanks,
Vivien
More information about the Bridge
mailing list