[Bridge] [PATCH net v2] net: bridge: Fix ethernet header pointer before check skb forwardable

wangyunjian wangyunjian at huawei.com
Wed Jan 16 09:09:43 UTC 2019



> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com]
> Sent: Tuesday, January 15, 2019 5:22 PM
> To: wangyunjian <wangyunjian at huawei.com>; netdev at vger.kernel.org
> Cc: xudingke <xudingke at huawei.com>; bridge at lists.linux-foundation.org;
> Nkolay Aleksandrov <nikolay at cumulusnetworks.com>; Roopa Prabhu
> <roopa at cumulusnetworks.com>
> Subject: Re: [PATCH net v2] net: bridge: Fix ethernet header pointer before
> check skb forwardable
> 
> On 15.01.2019 6:12, wangyunjian wrote:
> 
> > From: Yunjian Wang <wangyunjian at huawei.com>
> >
> > The skb header should be set to ethernet header before using
> > is_skb_forwardable. Because the ethernet header length has been
> > considered in is_skb_forwardable(including dev->hard_header_len
> > length).
> >
> > To reproduce the issue:
> > 1, add 2 ports on linux bridge br using following commands:
> > $ brctl addbr br
> > $ brctl addif br eth0
> > $ brctl addif br eth1
> > 2, the mtu of eth0 and eth1 is 1500
> > 3, send a 1504 packet from eth0 to eth1
> >
> > So the expect result is packet larger than 1500 cannot pass through
> > eth0 and eth1. But currently, the packet passes through success, it
> > means eth1's mtu limit donen't take effect.
> 
>     Doesn't. And MTU.

Thanks, I will fix them and send a new patch later.

Best regards,
	Yunjian
> 
> > Fixes: f6367b4660dd ("bridge: use is_skb_forwardable in forward path")
> > Cc: bridge at lists.linux-foundation.org
> > Cc: Nkolay Aleksandrov <nikolay at cumulusnetworks.com>
> > Cc: Roopa Prabhu <roopa at cumulusnetworks.com>
> > Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> [...]
> 
> MBR, Sergei


More information about the Bridge mailing list