[Bridge] [PATCH net v2] net: bridge: fix stale eth hdr pointer in br_dev_xmit

nikolay at cumulusnetworks.com nikolay at cumulusnetworks.com
Mon Feb 24 17:06:39 UTC 2020


On 24 February 2020 18:54:27 EET, Stephen Hemminger <stephen at networkplumber.org> wrote:
>On Mon, 24 Feb 2020 18:46:22 +0200
>Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:
>
>> -	eth = eth_hdr(skb);
>>  	skb_pull(skb, ETH_HLEN)
>
>you could just swap these two lines.

Can't, still caching the wrong mac_header offset. br_allowed_ingress() can change the head pointer and also the offsets inside. 




More information about the Bridge mailing list