[Bridge] [PATCH net-next 1/4] net: bridge: check port state before br_allowed_egress

Stephen Hemminger stephen at networkplumber.org
Thu Jan 23 16:25:42 UTC 2020


On Thu, 23 Jan 2020 15:28:04 +0200
Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:

>  	return ((p->flags & BR_HAIRPIN_MODE) || skb->dev != p->dev) &&
> -		br_allowed_egress(vg, skb) && p->state == BR_STATE_FORWARDING &&
> +		p->state == BR_STATE_FORWARDING && br_allowed_egress(vg, skb) &&
>  		nbp_switchdev_allowed_egress(p, skb) &&
>  		!br_skb_isolated(p, skb);
>  }

Maybe break this complex return for readability?


More information about the Bridge mailing list