[Bridge] [PATCH net-next] net: bridge: vlan: include stats in dumps if requested

[Nikolay Aleksandrov]

On 3/19/20 1:42 AM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>
> Date: Wed, 18 Mar 2020 15:03:25 +0200
> 
>> @@ -170,11 +170,13 @@ struct bridge_stp_xstats {
>>   /* Bridge vlan RTM header */
>>   struct br_vlan_msg {
>>   	__u8 family;
>> -	__u8 reserved1;
>> +	__u8 flags;
>>   	__u16 reserved2;
>>   	__u32 ifindex;
>>   };
> 
> I can't allow this for two reasons:
> 
> 1) Userspace explicitly initializing all members will now get a compile
>     failure on the reference to ->reserved1
> 
> 2) Userspace not initiailizing reserved fields, which worked previously,
>     might send in flags that trigger the new behavior.
> 
> Sorry, this is UAPI breakage.
> 

Hmm, fair enough. I'll respin with a new dump attribute which achieves the same.

Thanks.