[Bridge] [PATCH net v3] net: bridge: fix vlan stats use-after-free on destruction

Stephen Hemminger stephen at networkplumber.org
Wed May 20 15:50:54 UTC 2020


On Fri, 16 Nov 2018 18:50:01 +0200
Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:

> +	if (v->priv_flags & BR_VLFLAG_PER_PORT_STATS)
>  		free_percpu(v->stats);

Why not not v->stats == NULL as a flag instead?

Then the fact that free_percpu(NULL) is a Nop would mean less code
in the bridge driver.


More information about the Bridge mailing list