[Bridge] [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

[Jakub Kicinski]

On Mon, 7 Sep 2020 00:29:10 +0300 Nikolay Aleksandrov wrote:
> >> @@ -1641,16 +1647,7 @@ br_multicast_leave_group(struct net_bridge *br,
> >>   			if (p->flags & MDB_PG_FLAGS_PERMANENT)
> >>   				break;
> >>   
> >> -			rcu_assign_pointer(*pp, p->next);
> >> -			hlist_del_init(&p->mglist);
> >> -			del_timer(&p->timer);
> >> -			kfree_rcu(p, rcu);
> >> -			br_mdb_notify(br->dev, port, group, RTM_DELMDB,
> >> -				      p->flags | MDB_PG_FLAGS_FAST_LEAVE);  
> > 
> > And here we'll loose MDB_PG_FLAGS_FAST_LEAVE potentially?
> 
> Good catch, we will lose the fast leave indeed.
> This is a 1 line change to set the flag before notifying. Would you prefer
> me to send a v4 or a follow up for it?

I think it's cleaner if you send a v4. But not rush, I was planning to
apply this tomorrow morning PST, anyway.