[Bridge] [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag
nikolay at nvidia.com
Fri Feb 12 15:59:24 UTC 2021
On 12/02/2021 17:15, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean at nxp.com>
> For the netlink interface, propagate errors through extack rather than
> simply printing them to the console. For the sysfs interface, we still
> print to the console, but at least that's one layer higher than in
> switchdev, which also allows us to silently ignore the offloading of
> flags if that is ever needed in the future.
> Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com>
> Changes in v5:
> Changes in v4:
> - Adjust the commit message now that we aren't notifying initial and
> final port flags from the bridge any longer.
> Changes in v3:
> - Deal with the br_switchdev_set_port_flag call from sysfs too.
> Changes in v2:
> - br_set_port_flag now returns void, so no extack there.
> - don't overwrite extack in br_switchdev_set_port_flag if already
> net/bridge/br_netlink.c | 9 +++++----
> net/bridge/br_private.h | 6 ++++--
> net/bridge/br_switchdev.c | 13 +++++++------
> net/bridge/br_sysfs_if.c | 7 +++++--
> 4 files changed, 21 insertions(+), 14 deletions(-)
Acked-by: Nikolay Aleksandrov <nikolay at nvidia.com>
More information about the Bridge