[Bridge] [PATCH v2 net-next] net: bridge: check vlan with eth_type_vlan() method

Jakub Kicinski kuba at kernel.org
Fri Jan 15 04:14:09 UTC 2021

On Thu, 14 Jan 2021 18:23:44 -0800 menglong8.dong at gmail.com wrote:
> From: Menglong Dong <dong.menglong at zte.com.cn>
> Replace some checks for ETH_P_8021Q and ETH_P_8021AD with
> eth_type_vlan().
> Signed-off-by: Menglong Dong <dong.menglong at zte.com.cn>

This adds a new warning when built with W=1 C=1:

net/bridge/br_vlan.c:920:28: warning: incorrect type in argument 1 (different base types)
net/bridge/br_vlan.c:920:28:    expected restricted __be16 [usertype] ethertype
net/bridge/br_vlan.c:920:28:    got unsigned long val

More information about the Bridge mailing list