[Bridge] [PATCH net 0/2] net: bridge: multicast: fix automatic router port marking races

Nikolay Aleksandrov razor at blackwall.org
Sun Jul 11 09:56:27 UTC 2021

From: Nikolay Aleksandrov <nikolay at nvidia.com>

While working on per-vlan multicast snooping I found two race conditions
when multicast snooping is enabled. They're identical and happen when
the router port list is modified without the multicast lock. One requires
a PIM hello message to be received on a port and the other an MRD
advertisement. To fix them we just need to take the multicast_lock when
adding the ports to the router port list (marking them as router ports).
Tested on an affected setup by generating the required packets while
modifying the port list in parallel.


Nikolay Aleksandrov (2):
  net: bridge: multicast: fix PIM hello router port marking race
  net: bridge: multicast: fix MRD advertisement router port marking race

 net/bridge/br_multicast.c | 6 ++++++
 1 file changed, 6 insertions(+)


More information about the Bridge mailing list