[Bridge] [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call

Vladimir Oltean olteanv at gmail.com
Wed Mar 24 16:02:29 UTC 2021


On Wed, Mar 24, 2021 at 03:09:50PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
> 
> Addresses-Coverity: ("'Constant' variable guards dead code")
> Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean at nxp.com>


More information about the Bridge mailing list