[Bugme-new] [Bug 12538] New: xfs_fsr fails on 2.6.29-rc kernels

[bugme-daemon at bugzilla.kernel.org]

http://bugzilla.kernel.org/show_bug.cgi?id=12538

           Summary: xfs_fsr fails on 2.6.29-rc kernels
           Product: File System
           Version: 2.5
     KernelVersion: 2.6.29-rc1
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: XFS
        AssignedTo: xfs-masters at oss.sgi.com
        ReportedBy: pm at debian.org


Latest working kernel version: 2.6.28-rc9
Earliest failing kernel version: 2.6.29-rc1
Distribution: Debian
Hardware Environment: IBM Thinkpad T42
Software Environment: 
Problem Description:

xfs_fsr -v fails with:

XFS_IOC_SWAPEXT failed: ino=XXXXXXX: Invalid argument

Steps to reproduce:

Run xfs_fsr on a moderately fragmented filesystem.

Have git-bisected this to the following patch:

commit 743bb4650da9e2595d6cedd01c680b5b9398c74a
Author: sandeen at sandeen.net <sandeen at sandeen.net>
Date:   Tue Nov 25 21:20:06 2008 -0600

    [XFS] Move copy_from_user calls out of ioctl helpers into ioctl switch.

    Moving the copy_from_user out of some of the ioctl helpers will
    make it easier for the compat ioctl switch to copy in the right
    struct, then just pass to the underlying helper.

    Also, move common access checks into the helpers themselves,
    and out of the native ioctl switch code, to reduce code
    duplication between native & compat ioctl callers.

    Signed-off-by: Eric Sandeen <sandeen at sandeen.net>
    Reviewed-by: Christoph Hellwig <hch at lst.de>
    Signed-off-by: Lachlan McIlroy <lachlan at sgi.com>


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.