[Ce-android-mainline] Fwd: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c

Shuah Khan shuahkhan at gmail.com
Mon Jan 23 23:20:31 UTC 2012

Please see the following. We can drop pmem from our effort possibly. Any
thoughts and ideas.

-- Shuah

---------- Forwarded message ----------
From: Dima Zavin <dima at android.com>
Date: Mon, Jan 23, 2012 at 10:22 AM
Subject: Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in
printk () in pmem.c
To: Kashyap Gada <gada.kashyap at gmail.com>
Cc: gregkh at suse.de, rebecca at android.com, rschultz at google.com,
jgennis at google.com, devel at driverdev.osuosl.org, linux-kernel at vger.kernel.org

We really should just get rid of pmem.c altogether. We will remove it
from our android common tree too. We don't actually use it anymore in
any of our products. There are some legacy users of it, like Qualcomm,
but I'm sure they have a bunch of patches on top of it and thus are
maintaining it separately anyway.


On Fri, Jan 20, 2012 at 7:24 PM, Kashyap Gada <gada.kashyap at gmail.com>
> diff --git a/drivers/staging/android/pmem.c
> index 65ba61a..c589c0c 100644
> --- a/drivers/staging/android/pmem.c
> +++ b/drivers/staging/android/pmem.c
> @@ -831,7 +831,7 @@ static int pmem_connect(unsigned long connect, struct
file *file)
>        src_file = fget_light(connect, &put_needed);
>        DLOG("connect %p to %p\n", file, src_file);
>        if (!src_file) {
> -               printk("pmem: src file not found!\n");
> +               printk(KERN_ERR "pmem: src file not found!\n");
>                ret = -EINVAL;
>                goto err_no_file;
>        }
> @@ -934,7 +934,7 @@ int pmem_remap(struct pmem_region *region, struct
file *file,
>        if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
>                 !PMEM_IS_PAGE_ALIGNED(region->len))) {
> -               printk("pmem: request for unaligned pmem suballocation "
> +               printk(KERN_DEBUG "pmem: request for unaligned pmem
suballocation "
>                       "%lx %lx\n", region->offset, region->len);
>  #endif
>                return -EINVAL;
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/ce-android-mainline/attachments/20120123/6d29d003/attachment.html>

More information about the Ce-android-mainline mailing list