[cgl_discussion] Re: [PATCH-RFC} 3 of 4 - New problem logging macros, plus template generation

Jeff Garzik jgarzik at pobox.com
Mon Sep 23 19:12:02 PDT 2002


> +/*
> + * introduce(), problem(), and detail() macros
> + * Sample usage:
> + *	problem(LOG_ALERT, "Disk on fire!",
> + *		detail(disk, "%s", drive->name),
> + *		detail(temperature, "%d", drive->degC),
> + *		detail(action, "%s", "Put out fire; run fsck."));
> + */


action is policy, it does not belong in the kernel at all.  Further, I 
not sure we need to add all this new infrastructure when we could obtain 
the same result via [off the top of my head] printk standards in key 
drivers.

Why don't you start out with a list of requirements that you want to see 
from drivers?  Only then can we objectively evaluate our needs.

You are proposing a solution without really making it clear what 
problems you are solving.

	Jeff






More information about the cgl_discussion mailing list