[PATCH] mtd_blkdevs: Convert to use the kthread API
Eric W. Biederman
ebiederm at xmission.com
Thu Apr 19 12:13:22 PDT 2007
Christoph Hellwig <hch at infradead.org> writes:
> On Thu, Apr 19, 2007 at 12:55:28AM -0600, Eric W. Biederman wrote:
>> From: Eric W. Biederman <ebiederm at xmission.com> - unquoted
>> thread_run is used intead of kernel_thread, daemonize, and mucking
>> around blocking signals directly.
> Please don't do incomplete transitions like that. We don't really
> want people to use kthread_run, but not the kthread stopping
> mechanisms, because people will simply forget about that bit and
> we'll never get rid of the enormous amount of, erm creativity, in
> handling kernel thread stopping.
> This is just the first patch in your series where the thread is mutable,
> but it equally applies to all following patches where this is the case
I don't really care about the creativity. Although it would
be nice if it wasn't there. I deliberately left it in so I would be
certain my patches were correct.
I care about killing the maintenance and forward development roadblocks
that are kernel_thread and daemonize. And the user interface problem
that is handling signals in kernel threads.
More information about the Containers