[PATCH 2/20] Move exit_task_namespaces()

xemul at openvz.org xemul at openvz.org
Tue Aug 7 02:29:38 PDT 2007

Makve task release its namespaces after it has reparented all his children
to child_reaper, but before it notifies its parent about its death.

The reason to release namespaces after reparenting is that when task exits
it may send a signal to its parent (SIGCHLD), but if the parent has already
exited its namespaces there will be no way to decide what pid to dever to
him - parent can be from different namespace.

The reason to release namespace before notifying the parent it that when
task sends a SIGCHLD to parent it can call wait() on this taks and release
it. But releasing the mnt namespace implies dropping of all the mounts in
the mnt namespace and NFS expects the task to have valid sighand pointer.

Thanks to Oleg for pointing out some races that can apear and helping with
patches and fixes.

Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
Cc: Oleg Nesterov <oleg at tv-sign.ru>


 exit.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- ./kernel/exit.c.ve2	2007-07-27 12:45:46.000000000 +0400
+++ ./kernel/exit.c	2007-07-27 12:46:08.000000000 +0400
@@ -796,6 +796,7 @@ static void exit_notify(struct task_stru
 	 *	jobs, send them a SIGHUP and then a SIGCONT.  (POSIX
+	exit_task_namespaces(tsk);
@@ -1003,7 +1004,6 @@ fastcall NORET_TYPE void do_exit(long co
 	tsk->exit_code = code;
-	exit_task_namespaces(tsk);

More information about the Containers mailing list