[Devel] [PATCH 4/4] Use task_pgrp() in autofs/autofs4

sukadev at us.ibm.com sukadev at us.ibm.com
Wed Feb 28 19:41:34 PST 2007


Eric W. Biederman [ebiederm at xmission.com] wrote:
| Cedric Le Goater <clg at fr.ibm.com> writes:
| 
| > sukadev at us.ibm.com wrote:
| >> From: Sukadev Bhattiprolu <sukadev at us.ibm.com>
| >> Subject: [PATCH 4/4] Use task_pgrp() in autofs/autofs4
| >> 
| >> Replace process_group(tsk) with pid_nr(task_pgrp(tsk)) in autofs and autofs4.
| >
| > you will need EXPORT_SYMBOL_GPL for pid_nr()

Cedric: do we need the export in -mm or just in -lxc ? In -mm, for now,
this is an inline function in pid.h and should just get included into
the file(s) no ?

| 
| This bit I can agree with.  Because you need that at least for
| the seq_printf.
| 
| However all of the pid_nr(task_pgrp) stuff just appears to be painful
| noise.  

Ok. I thought they were low priority but required eventually.

| 
| I have largely given up on review this patch set until that is fixed.

I am sending out the patches with the noise cancelled :-) Would like
to send them out to akpm in a few days.

Suka



More information about the Containers mailing list