[PATCH 15/15] Hooks over the code to show correct values to user

Oleg Nesterov oleg at tv-sign.ru
Sun Jul 29 07:31:36 PDT 2007


On 07/26, Pavel Emelyanov wrote:
>
> int
> kill_proc(pid_t pid, int sig, int priv)
> {
> -	return kill_proc_info(sig, __si_special(priv), pid);
> +	int ret;
> +
> +	rcu_read_lock();
> +	ret = kill_pid_info(sig, __si_special(priv), find_pid(pid));
> +	rcu_read_unlock();
> +	return ret;
> }

I think this is wrong. kill_proc() should behave the same as kill_proc_info(),
so this change is not needed. With this patch they use different namespaces
to find the task, this is not consistent.

(sadly, this patch is huge, very difficult to review).

Oleg.



More information about the Containers mailing list