[PATCH 2/7] containers (V7): Cpusets hooked into containers

Srivatsa Vaddagiri vatsa at in.ibm.com
Wed Mar 7 06:52:57 PST 2007


On Mon, Feb 12, 2007 at 12:15:23AM -0800, menage at google.com wrote:
> -	mutex_lock(&callback_mutex);
> -	list_add(&cs->sibling, &cs->parent->children);
> +	cont->cpuset = cs;
> +	cs->container = cont;
>  	number_of_cpusets++;
> -	mutex_unlock(&callback_mutex);

What's the rule to read/write number_of_cpusets? The earlier cpuset code was
incrementing/decrementing under callback_mutex, but now we aren't. How safe is 
that? 

The earlier cpuset code also was reading number_of_cpusets w/o the
callback_mutex held (atleast in cpuset_zone_allowed_softwall). Is that safe?

-- 
Regards,
vatsa



More information about the Containers mailing list