[Devel] [RFC][PATCH 0/16] Enable cloning of pid namespace

Badari Pulavarty pbadari at gmail.com
Tue May 29 10:12:33 PDT 2007


On Tue, 2007-05-29 at 08:48 -0700, Dave Hansen wrote:
> On Tue, 2007-05-29 at 14:29 +0400, Pavel Emelianov wrote:
> > sukadev at us.ibm.com wrote:
> > > Dave, Serge,
> > > 
> > > Here is my current pid namespace patchset. There are still a couple of
> > > issues I am investigating, but appreciate any feedback.
> > > 
> > > Suka
> > > 
> > 
> > I tried to compile your patches with CONFIG_PID_NS=n and got this:
> > 
> >   CC      kernel/configs.o
> > kernel/pid.c:361: warning: function declaration isn't a prototype
> > kernel/pid.c: In function `dup_struct_pid':
> > kernel/pid.c:489: warning: initialization makes pointer from integer without a cast
> 
> Could you send along your actual .config?

Not needed :(

Index: linux-2.6.21/kernel/pid.c
===================================================================
--- linux-2.6.21.orig/kernel/pid.c	2007-05-25 09:06:30.000000000 -0700
+++ linux-2.6.21/kernel/pid.c	2007-05-29 10:07:39.000000000 -0700
@@ -357,7 +357,7 @@
 
 #else
 
-static int alloc_pid_ns()
+static struct pid_namespace *alloc_pid_ns(void)
 {
 	static int warned;
 
@@ -365,7 +365,7 @@
 		printk(KERN_INFO "WARNING: CLONE_NEWPID disabled\n");
 		warned = 1;
 	}
-	return 0;
+	return NULL;
 }
 
 void zap_pid_ns_processes(struct pid_namespace *pid_ns)




More information about the Containers mailing list