[RFC][ for -mm] memory cgroup enhancements take3 [1/9] fix try_to_free_mem_cgroup_pages() numa handling

Balbir Singh balbir at linux.vnet.ibm.com
Tue Oct 30 11:28:00 PDT 2007


Dave Hansen wrote:
> On Tue, 2007-10-30 at 20:14 +0900, KAMEZAWA Hiroyuki wrote:
>> -       for_each_online_node(node) {
>> -               zones =
>> NODE_DATA(node)->node_zonelists[target_zone].zones;
>> -               if (do_try_to_free_pages(zones, sc.gfp_mask, &sc))
>> +       zones = NODE_DATA(node)->node_zonelists[target_zone].zones;
>> +       if (do_try_to_free_pages(zones, sc.gfp_mask, &sc))
>>                         return 1;
>> -       }
>>         return 0;
>>  }
>>  #endif 
> 
> Am I reading the diff wrong, or is that return indented too far?
> 
> -- Dave

Good catch! It is indeed indented one additional tab away from where it
should be

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL


More information about the Containers mailing list