[PATCH 2/5] pid: use namespaced iteration on processes while using sysrq

Dave Hansen dave at linux.vnet.ibm.com
Thu Dec 18 08:58:09 PST 2008


On Thu, 2008-12-18 at 22:12 +0530, Gowrishankar M wrote:
> From: Gowrishankar M <gomuthuk at linux.vnet.ibm.com>
> 
> At present, while signalling processes using sysrq, process iteration
> goes beyond current PID namespace.
> 
> Below patch uses one of the proposed namespace iteration macros to fix
> the boundary.

I think this is a really bad idea.  Maybe not for 'echo t
> /proc/sysrq-trigger', but definitely for the console triggers.

The sysrq code can get called via the serial console code.  That may
even get processed during softirqs so the current process may not have
anything to do with what the user is typing into.  That's just one
example.  I bet there are a bunch more.

What problem does this patch solve anyway?

-- Dave



More information about the Containers mailing list