[patch 4/9] unprivileged mounts: propagate error values from clone_mnt

Miklos Szeredi miklos at szeredi.hu
Tue Jan 15 02:15:55 PST 2008

> Quoting Miklos Szeredi (miklos at szeredi.hu):
> > From: Miklos Szeredi <mszeredi at suse.cz>
> > 
> > Allow clone_mnt() to return errors other than ENOMEM.  This will be used for
> > returning a different error value when the number of user mounts goes over the
> > limit.
> > 
> > Fix copy_tree() to return EPERM for unbindable mounts.
> > 
> > Don't propagate further from dup_mnt_ns() as that copy_tree() can only fail
> > with -ENOMEM.
> I see what you're saying, but it just seems like it's bound to be more
> confusing this way.

Ah yes, this is indeed confusing.  Last time dup_mnt_ns() returned a
namespace pointer or NULL.  But now I see it returns an ERR_PTR(error)
instead, which means it's cleaner to just propagate the error value.
I'll fix this.


More information about the Containers mailing list