[PATCH 12/15] driver core: Implement tagged directory support for device classes.

Tejun Heo htejun at gmail.com
Fri Jul 4 00:50:40 PDT 2008

Eric W. Biederman wrote:
> This patch enables tagging on every class directory if struct class
> has a tag_type.
> In addition device_del and device_rename were modified to uses
> sysfs_delete_link and sysfs_rename_link respectively to ensure
> when these operations happen on devices whose classes have
> tag_ops that they work properly.
> Signed-off-by: Eric W. Biederman <ebiederm at xmission.com>
> Signed-off-by: Benjamin Thery <benjamin.thery at bull.net>

Okay, I went through the users this time but I still think
determine-tags-by-callbacks is a bad idea.  Please just add const void
*tag to kobject and set it during initialization.  If you want to move a
device from one tag to another, implement kobject_rename_tagged(kobj,
new_name, new_tag).

The determine-tag-by-callback basically multiplexes basic functions to
do tag-specific things which are determined by ktype callback called
back from down the layer.  It's simply a bad interface.  Those
operations become something else depending on how those callbacks
behave.  That's unnecessarily subtle.  Advertising what it's gonna do in
the function name and as arguments is way more straight forward and it's
not like determining or renaming tags should be done asynchronously.

I personally think it would be better to make tags explicit in the mount
interface too but if extracting ns information from the mounting process
is what's currently being done, well...

I'm sorry but Nacked-by: Tejun Heo <tj at kernel.org>



More information about the Containers mailing list