[PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child_reaper

Daniel Hokka Zakrisson daniel at hozac.com
Thu Jul 17 11:21:37 PDT 2008


Eric W. Biederman wrote:
> Daniel Hokka Zakrisson <daniel at hozac.com> writes:
>
>> p->pid == 1 is insufficient when there are multiple pid namespaces.
>> Instead, check whether the task is in the current task's
>> child reaper's thread group.
>
> We should just drop the check for init as it is redundant.

I'm not sure what you mean? Without protecting init here, kill -s 9 -- -1
will kill it (i.e. the init in the pid namespace). E.g.:
# vspace --new --pid --mount -- bash
# bash -c 'kill -s 9 -- -1'
will kill off all those processes, and dispose of the pid namespace.

> Eric

-- 
Daniel Hokka Zakrisson


More information about the Containers mailing list