[PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child_reaper

Eric W. Biederman ebiederm at xmission.com
Thu Jul 17 11:51:38 PDT 2008


"Daniel Hokka Zakrisson" <daniel at hozac.com> writes:

> Eric W. Biederman wrote:
>> Daniel Hokka Zakrisson <daniel at hozac.com> writes:
>>
>>> p->pid == 1 is insufficient when there are multiple pid namespaces.
>>> Instead, check whether the task is in the current task's
>>> child reaper's thread group.
>>
>> We should just drop the check for init as it is redundant.

Sorry that was a half truth.  Outside of the context of pid namespaces it is true.

In the context of pid namespaces it is false because we haven't merged the patches
to drop signals from inside the pid namespace on the way to init.

So it is a check that _should_ be redundant.

Eric


More information about the Containers mailing list