memrlimit controller merge to mainline

Hugh Dickins hugh at veritas.com
Fri Jul 25 10:38:49 PDT 2008


On Fri, 25 Jul 2008, Balbir Singh wrote:
> 
> I'll try and recreate the problem and fix it. If memrlimit_cgroup_uncharge_as()
> created the problem, it's most likely related to mm->owner not being correct and
> we are dereferencing the wrong memory.
> 
> Thanks for the bug report, I'll look further.

Good luck!  I have only seen it once, on a dual-core laptop; though
I don't remember to try swapoff while busy as often as I should (be
sure to alternate between a couple or more of swapareas, so you can
swap a new one on just before swapping an old one off, to be pretty
sure of success).

May be easier to find in the source: my suspicion is that a bad
mm_users assumption will come into it.  But I realize now that it
could be entirely unrelated to memrlimit, just that uncharge_as
was the one to get hit by bad refcounting elsewhere.

Oh, that reminds me, I never reported back on my res_counter warnings
at shutdown: never saw them again, once I added in the set of changes
you came up with shortly after that - thanks.

Hugh


More information about the Containers mailing list