[PATCH 1/1] User namespaces: fix refcounting

Serge E. Hallyn serue at us.ibm.com
Wed Oct 8 07:42:46 PDT 2008


Hi David,

attached is a respin of the three user namespace cleanup patches I've
been trying to push upstream.  I've ported them on top of James'
next-creds-subsys branch (and consolidated into a single patch bc the
splitup wasn't perfect anyway).

These are prep patches on top of which I can then start the real user
namespace work.  If this looks ok, then I will try to get it into
linux-next after next-creds-subsys goes in there.

Perhaps the most objectionable part of this to you may be the
__task_commit_creds().  In the case of clone(CLONE_NEWUSER),
current is not the task which will receive the new credentials, so
I need to be able to set creds on another task.  The other task is
however still being created, so it is safe in this case.  I kept
__task_commit_creds out of header files assuming that noone else
should be able to use it, ever.

Does this look ok to you?

thanks,
-serge



More information about the Containers mailing list