[PATCH] CRED: Fix creds refcounting in lookup_user_key()

David Howells dhowells at redhat.com
Tue Oct 14 14:52:49 PDT 2008


Make lookup_user_key() at all return points drop the reference to the current
creds that it took at the top of the function.

Signed-off-by: David Howells <dhowells at redhat.com>
Tested-by: Serge Hallyn <serue at us.ibm.com>
---

 security/keys/process_keys.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
index e40f61d..2d6076d 100644
--- a/security/keys/process_keys.c
+++ b/security/keys/process_keys.c
@@ -667,6 +667,7 @@ try_again:
 		goto invalid_key;
 
 error:
+	put_cred(cred);
 	return key_ref;
 
 invalid_key:



More information about the Containers mailing list