ptem01 LTP failure in ttydev-0909

sukadev at sukadev at
Thu Sep 11 13:11:59 PDT 2008


LTP testcases/kernel/pty/ptem01 is failing on ttydev-0909. The test
passed on ttydev-0828.

The test changes the window size using the slave-fd and expects that
it won't affect the window-size on master-fd. With this change, we
return the slave's window size and test fails.

I suspect that it is due to following change in ttydev.  

Is the test bogus now ?


commit 4f0fa9c9e6557442b583a687066bebd607246220
Author: Alan Cox <alan at>
Date:   Mon Sep 8 13:49:19 2008 -0700

    tty: Termios locking - sort out real_tty confusions and lock reads

    This moves us towards sanity and should mean our termios locking is now
    complete and comprehensive.

diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 69b1766..7eabfbb 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -2595,7 +2595,7 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        case TIOCSTI:
                return tiocsti(tty, p);
        case TIOCGWINSZ:
-               return tiocgwinsz(tty, p);
+               return tiocgwinsz(real_tty, p);

More information about the Containers mailing list