[PATCH 10/10] Document usage of multiple-instances of devpts

Serge E. Hallyn serue at us.ibm.com
Mon Sep 22 06:29:37 PDT 2008


Quoting sukadev at linux.vnet.ibm.com (sukadev at linux.vnet.ibm.com):
> Alan Cox [alan at lxorguk.ukuu.org.uk] wrote:
> | Ok I'm happy with this patch set. It appears correct as far as the tty
> | side is concerned, it looks sensible in terms of interface with the
> | devpts layer.
> 
> Alan, Peter: Thanks for review and feedback.
> 
> | 
> | Really depends what everyone else thinks about the vfs bits and the API
> 
> Maybe I should post to fsdevel, manpages, and lkml for the vfs/api changes. 
> 
> Serge, Eric, Pavel: Any comments on the patchset before I do that ?

I didn't have any comments on the code, it looked fine.  But the
kernel locked up for me trying to ssh into a container last night.
Complete lockup so haven't yet figured out why.

Oh, actually I did have a comment on code - finding that config
variable was dreadful :)  Now obviously it makes sense on the
one hand, but finding that plus CONFIG_NET_NS plus the other
namespace variables is getting ugly.

-serge


More information about the Containers mailing list