[PATCH 08/10] Define get_sb_ref()
sukadev at linux.vnet.ibm.com
sukadev at linux.vnet.ibm.com
Sat Sep 27 13:29:24 PDT 2008
Dave Hansen [dave at linux.vnet.ibm.com] wrote:
| On Fri, 2008-09-26 at 14:21 -0700, sukadev at linux.vnet.ibm.com wrote:
| > Dave Hansen [dave at linux.vnet.ibm.com] wrote:
| > | On Fri, 2008-09-12 at 10:53 -0700, sukadev at us.ibm.com wrote:
| > | > + * But for single-mount semantics, devpts cannot use get_sb_single(),
| > | > + * because get_sb_single()/sget() find and use the super-block from
| > | > + * the most recent mount of devpts. But that recent mount may be a
| > | > + * 'newinstance' mount and get_sb_single() would pick the newinstance
| > | > + * super-block instead of the initial super-block.
| > |
| > | Can't you just override the test() function to get what you want here?
| >
| > get_sb_single() does not take a test() parameter and so I would still
| > need a get_sb_ref() or get_sb_special() interface right ?
| >
| > This special interface could call sget() with a custom-test function,
| > to get the super-block. But in case of devpts, we already have the
| > super-block. So we don't need to call sget(). We just need get a reference
| > and remount.
|
| Well, you shouldn't be using get_sb_single() at all any more, right?
How about something along these lines.
(applies on current devpts patchset. Touch tested on 2.6.27-rc6+ttydev-0918)
Suka
---
More information about the Containers
mailing list