[PATCH 5/5] c/r: Add AF_UNIX support (v7)

Serge E. Hallyn serue at us.ibm.com
Tue Aug 4 14:17:42 PDT 2009


Quoting Dan Smith (danms at us.ibm.com):
> SH> Does this re-use of tmp make sense?  (It only would if
> SH> dev_alloc_skb() did a generic prealloc for any subsequent
> SH> skb_clone() which i don't think is the case)
> 
> No, this is cruft.
> 
> SH> Also, do you need any kind of lock on the queue to make this walk
> SH> safe, or do ensure below (sorry i'm slow and haven't gotten there)
> SH> that all tasks with an open fd for either end of this sock are
> SH> frozen?
> 
> Hmm, it seems that holding the lock while processing the queue isn't
> really the way to go.  Perhaps comparing the pid of the other end of
> the socket against the list in the context is best?

I don't understand.  Which pid?


More information about the Containers mailing list