[RFC][v4][PATCH 0/7] clone_with_pids() system call

Eric W. Biederman ebiederm at xmission.com
Wed Aug 12 20:45:43 PDT 2009

Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com> writes:

> To support application checkpoint/restart, a task must have the same pid it
> had when it was checkpointed.  When containers are nested, the tasks within
> the containers exist in multiple pid namespaces and hence have multiple pids
> to specify during restart.
> This patchset implements a new system call, clone_with_pids() that lets a
> process specify the pids of the child process.
> Patches 1 through 5 are helpers and we believe they are needed for application
> restart, regardless of the kernel implementation of application restart.

I'm not very impressed.

- static int alloc_pidmap(struct pid_namespace *pid_ns)
+ static int alloc_pidmap(struct pid_namespace *pid_ns, int pid_max, int last_pid)

Do that.

That is pass in pid_max and last_pid, and you don't have to do weird
things in alloc_pidmap, and no set_pidmap is needed.

No changes to copy_process are needed it already takes a struct pid

I haven't been following closely what is gained by having a clone_with_pids

As for new namespaces that don't need to happen at process creation time
(which is just about anything that is left) we can create a new syscall that
unshares just that one.


More information about the Containers mailing list