[PATCH 5/9] [RFC] Remove cgroup_subsys.root pointer

Paul Menage menage at google.com
Thu Jul 2 02:32:27 PDT 2009


On Thu, Jul 2, 2009 at 2:04 AM, Louis Rilling<Louis.Rilling at kerlabs.com> wrote:
>> +/* Find the root for a given subsystem */
>> +static struct cgroupfs_root *find_root(struct cgroup_subsys *ss)
>> +{
>> +     int id = ss->subsys_id;
>> +     struct cgroupfs_root *root, *res = NULL;
>> +     for_each_root(root) {
>> +             if (root->subsys_bits && (1UL << id)) {
> Should be &, not && ------------------^^
>

Good catch. This is only used by cgroup_clone() via ns_cgroup, and I
hadn't done any testing with namespace creation and ns_cgroup.

Paul


More information about the Containers mailing list