[PATCH] cgroup: fix reverse unlock sequence in cgroup_get_sb

Paul Menage menage at google.com
Tue Jul 21 09:03:01 PDT 2009


On Tue, Jul 21, 2009 at 3:25 AM, Xiaotian Feng<dfeng at redhat.com> wrote:
> In cgroup_get_sb, the lock sequence is:
>        mutex_lock(&inode->i_mutex);
>        mutex_lock(&cgroup->mutex);
> so the last unlock sequence should be:

Make this "so for consistency the last ..." ?

Maybe make the patch title "Make unlock sequence in cgroup_get_sb
consistent" so someone looking through the change logs for fixes to
backport doesn't wrongly thing that this fixes any bug"?

>        mutex_unlock(&cgroup->mutex);
>        mutex_unlock(&inode->i_mutex);
>
> Signed-off-by: Xiaotian Feng <dfeng at redhat.com>

Acked-by: Paul Menage <menage at google.com>

Paul


More information about the Containers mailing list