[RFC][PATCH] flexible array implementation v4

Paul Menage menage at google.com
Fri Jul 24 08:07:04 PDT 2009


On Thu, Jul 23, 2009 at 8:08 PM, KAMEZAWA
Hiroyuki<kamezawa.hiroyu at jp.fujitsu.com> wrote:
> On Fri, 24 Jul 2009 11:02:28 +0800
> Li Zefan <lizf at cn.fujitsu.com> wrote:
>
>> Dave Hansen wrote:
>> > Remaining issues:
>> > - How should we deal with out-of-range indexes, especially
>> >   in flex_array_get() which returns void*?  ERR_PTR()?
>> >   BUG_ON()?  return NULL (current behavior)?
>> > - Should care be taken not to allow a flex_array_get() to
>> >   an index where no flex_array_put() was done?
>> > - Should we decay further than just packing things into the
>> >   'base' page?  Should we actually kmalloc() less than a
>> >   page at times when it will fit?
>> >
>>
>> I sugguest find some candidate users and see how this flex_array
>> fits them.
>>
> Hmm, can't we rewrite cgroup->tasks file using this ?
> I'll try some if I have time.

We could, but I've been leaning more towards Eric's suggestion of
avoiding allocating the array entirely - see

http://lkml.org/lkml/2009/7/15/226
http://lkml.org/lkml/2009/7/21/393

Paul


More information about the Containers mailing list